allow room creation with an exception list...
Closed this issue · 4 comments
allow the user to specify one or more addresses (grouping using NFTs or POAPs doesn't really make sense in this context), cf., https://docs.google.com/document/d/193d9IQa33QfnxHnSW-lrv3PgjW2ztZXQuSqQW3nxVYU/edit#heading=h.ycyh8w19cvd2
Verification done on https://talk.brave.software
POAP gating with Exception list
- Verified if address added in exception list without POAP doesn't let the user join the call - ✅
- Verified if address added in exception list with a valid POAP still doesn't let the user join the call - ✅
POAP gating with Allow list
- Verified if address added in allow list without POAP lets the user join the call - ✅
- Verified if address added in allow list with a valid POAP lets the user join the call - ✅
NFT gating with Exception list
- Verified if address added in exception list without NFT doesn't let the user join the call - ✅
- Verified if address added in exception list with a valid NFT still doesn't let the user join the call - ✅
NFT gating with Allow list
- Verified if address added in allow list without NFT lets the user join the call - ✅
- Verified if address added in allow list with a valid NFT lets the user join the call - ✅
BAT gating with Exception list
- Verified if address added in exception list without BAT balance doesn't let the user join the call - ✅
- Verified if address added in exception list with BAT balance still doesn't let the user join the call - ✅
BAT gating with Allow list
- Verified if address added in allow list without BAT balance lets the user join the call - ✅
- Verified if address added in allow list with BAT balance lets the user join the call - ✅
Multiple address in Exception list
- Verified able to add multiple address in exception list and every address is NOT allowed to join the call irrespective of the POAP/NFT/BAT gating - ✅
Multiple address in Allow list
- Verified able to add multiple address in allow list and every address is allowed to join the call irrespective of the POAP/NFT/BAT gating - ✅
Misc checks
- Verified same address can't be added in both Exception list and Allow list - ✅
- Verified address verification is done for non-Ethereum address and shows error - ✅
- Verified error message is shown for Unstoppable domains linked to an Address - ✅ (no address resolution implemented)
- Encountered #1211 & #1212
Verified able to setup Premium Brave Talk rooms on the following browsers on Desktop
Chrome - ✅
Chrome.-.Premium.mp4
FireFox - ✅
FF-Premium.mp4
Opera - ✅
Opera.-.Premium.mp4
Edge - ✅
Edge.-.Premium.mp4
Safari - ✅ (exception is can't create a meeting link to share)
Safari.-.Premium.mp4
DuckDuckGo - ✅ (exception is can't create a meeting link to share)
DDG.-.Premium.mov
Verified able to setup premium calls on the following browsers on Android/iOS
| Chrome | Android | iOS |
| ✅ | ✅ | |
| Firefox | Android | iOS |
| ✅ | Partial ✅ (able to start but no support for 8x8 message is shown | |
| Edge | Android | iOS |
| ✅ | Partial ✅ (able to start but no support for 8x8 message is shown | |
| Safari | Android | iOS |
| ❌ (No Safari support) | ✅ |
Note: iOS doesn't provide an option to Create link option when premium account is enabled