brave/brave-talk

After Web3 call, NFT avatar remains in non-Web3 calls

bcaller opened this issue · 5 comments

bcaller commented

There is no way to remove the NFT avatar from the UI. You need to clear local storage.

Not sure if we should always hide the avatar in non-Web3 calls (since you can't normally select an avatar), or provide an option to hide it.

mrose17 commented

After consideration, here is the way forward: if the avatar is set in a Web3 call, then it should be put into localStorage ...

It would be ideal to be able to use the avatar and not store it; however, that may be difficult to implement. as such, it may be better to simply add a hook on receiving an event such asdataChannelOpen (which occurs after the avatar is set and stored) to remove the value from localStorage.

srirambv commented

There seems to be an issue with picking the right avatar.

BT-966.mp4
srirambv commented

This is mostly fixed for the part where non-web3 calls use the default avatar. But selecting an avatar for Web3 calls is showing the wrong one when call is initiated

brave_D8UhBEaEwI.mp4
mrose17 commented

@srirambv - for this issue, let's focus only on web3 vs. non-web3 with the following properties:

  • for web3, if i select an avatar does it show up in the call? (expected: yes)
  • for web3, if I go back to the same room, does the same avatar show up in the call? (expected: yes)
  • for web3, if I go to a different room and do not select an avatar, does any avatar show up in the call? (expected: no)
  • for web3, if i go to a different room and select a different avatar, does the new avatar show up in the call? (expected: yes0
  • for non-web3, do i see an avatar from an earlier web3 call (expected: no)

anything related to the wrong avatar being selected should be indicated on #1157

thanks!

srirambv commented

The following scenarios checks out right.

  • For Web3, select an avatar before starting call and the same avatar shows as expected - ✅
  • For Web3, going back to the same room, the same avatar is shown for the call - ✅
  • For Web3, going to a different room and not selecting an avatar, doesn't show any avatar - ✅
  • For Web3, going to a different room and selecting a different avatar shows the new avatar selected - ✅
  • For non-Web3, no avatar selected from Web3 call is shown when creating and joining the call - ✅