brendan-duncan/archive

Can't modify archive files

YancyHsu opened this issue · 3 comments

YancyHsu commented

the code cant work now
_archive.files[index] = archiveFile;
maybe UnmodifiableListView block it

archive/lib/src/archive.dart

Line 14 in 4c94c0a

List<ArchiveFile> get files => UnmodifiableListView(_files);

brendan-duncan commented

That had to be removed because it caused the archive's cache to become invalid.

I just pushed an alternative to git, I'll publish soon:
_archive[index] = archiveFile;

  • 👍1
  • 😄1
YancyHsu commented

That had to be removed because it caused the archive's cache to become invalid.

I just pushed an alternative to git, I'll publish soon: _archive[index] = archiveFile;

i modified the \archive-3.4.10\lib\src\archive.dart

List get files => UnmodifiableListView(_files);

to

List get files => _files;

instead temprorily

brendan-duncan commented

I'll have to remove the name caching if I made files a modifiable list, because if you change the list directly, the name cache (_fileMap) could become invalid.