JS Not Loaded on GitHub Enterprise
Closed this issue · 17 comments
First of all, great plugin!
This worked well for me for a couple weeks and now I'm unable to get the js to load on GH enterprise pages. It works as expected on non-GHE pages.
I've disabled all other plugins and I still can't get GHE PR files to toggle. When I use the dev tools inspector I can see that the plugin never loads its js/css. However, regular GH pages load the js/css correctly.
I get prompted for new permissions when I enter the GHE url in the options, but I see no change in functionality. I'm wondering if other GHE users have experienced recent degradation.
Thanks for any help. This plugin helps very well w/ managing PRs.
Thanks @rianrainey, I was able to test the prompting for new permissions, but I was unable to test the content script being loaded and working properly because I don't have github enterprise. It is pretty simple code, especially given that the permissions are being requested... would you care to take a shot at a PR to solve this issue?
It does have the potential to turn into something much more difficult... as maybe we can't conditionally load the content script based on the optional permissions... we'll have to see. If you don't think you can figure it out or don't care to, I will certainly attempt to fix it, but I won't be able to look at it for a week as I'm about to leave on holidays.
Thanks for logging the bug!
Same thing for me too - the app used to work for me and stopped working on github enterprise
OK, as I mentioned, I was able to test that the permissions prompting still works, but I will either have to get creative to see if I can find out how to fix the rest, or accept a PR from someone who uses github enterprise (which is how this extension ended up supporting enterprise in the first place).
It looks like I can start a free trial of enterprise... so that could be an option for me.
I'm happy to try something sometime, but don't have any experience with developing chrome extensions, so would need to climb the learning curve a bit.
I finally started looking into this this weekend. I believe the problem is that the content script is never told to load. Since switching to the optional permissions, the content script would have to be programatically injected into those pages, and I'm not seeing that happen anywhere.
I have what SHOULD be the fix in place but it wasn't quite working and I ran out of time... but it should be fixable from here, and I shouldn't have to widen any permissions which is great.
👍
Hey all,
I just pushed up version 2.10.1 that SHOULD address this issue. I tested it using my own trial version of Github Enterprise, and found several issues that I addressed. I also found even more corner cases and bugs of how the plugin loads, but those are somewhat unrelated to Github Enterprise and more to github's mixed use of full page reloads and client templating.
I am going to do a complete rewrite of this extension soon (I was hoping the need for this extension would have died soon after, but Github apparently has no interest in adding it), so I'll address the corner bugs then, but GHE functionality SHOULD be returned.
Can you guys test it and let me know... and if we are good I'll close the bug!
Will do! 2.10.1 not showing up in the store for me yet.
Very much appreciate your work on this - thanks. I miss the collapsing files functionality every day :).
Got latest version.
Collapsing / expanding files works - which is awesome and is mostly what I wanted.
The checkboxes to show/hide added and deleted lines are there but don't work.
Tried them on github.com and they work fine but not on the enterprise page - checking and unchecking them doesn't do anything that I can see.
Thanks a lot.
It had this issue with Version: 2.10.3
An easier solution is to do the following:
- install the extension
- add your GHE URL
- go to chrome extensions page
- disable the extension and enable it back again
Hey @lzelevinsky, sorry, I somehow missed your comment about the checkboxes. I assume they are still not working?
I just removed my github enterprise VM a few days ago too, ugh, and my free trial is probably over. I probably won't fix this feature soon, but I will try and fix it sometime after the holidays. Thanks for letting me know!
If one of you with GitHub Enterprise wants to try out the changes in #47 , that'd be awesome.
I just tried #47 and I'm still not able to get it to work. Here is my error:
Oh boy. Yeah that's a typo.
@rianrainey I fixed that, if you'd like to try again.
As soon as he confirms it, we can get it into the released version!