bresam/ivory-google-map

Unit tests: Fix errors and deprecations

bresam opened this issue · 5 comments

bresam commented

Need to fix

  • errors
  • deprecations
bresam commented

@Chris53897
I have tested with --prefer-lowest dependencies and fixed the last unit test error related to outdated placeIDs used in tests.

bresam commented

@Chris53897 do you think we should try to enable functional tests too?

Of course you can enable them and check the ci for the actual result.
I did not get the permission from the company for the Google Maps API Key.
So i am afraid i can not invest too much time anymore here to help here. Sorry

bresam commented

No problem, thank you very much for the work you did on that project, i really appreciate this!
Have you had the opportunity to test it on a real world sf7 project yet?

I got it installed and running without errors (that was a big step until the last try)
The Form-Field is displayed, but not working for missing key. This is expected.
If i find some free time, i will create a personal Google Maps API Key to test it.
But for now i need to keep up on some other tasks.