Remove "nikic/php-parser": "^1.4" dependency

Question

krewetka opened this issue 5 years ago · 4 comments

@bresam I know that you might not have time but would be great if you could check if we can remove this really outdated dependency 🤔

And this one is blocking updating other packages where many of them require versions 3 or 4 already.

I have checked and I don't see any use of anything from namespace PhpParser or any use of php-parser binary.

Would be great if you could double check it and then we could simple remove it from composer.json.

Answer 1 · 2020-10-08T09:05:57.000Z

It seems you are right, unittests also work still fine.
I've removed that dependency.

Feel free to create a PR next time.

Best Samuel

Answer 2 · 2020-10-08T09:16:44.000Z

Yeap, next time I will create PR.

Just wasn't 100% sure if I am right ;)

Thanks for really quick response.

Btw, it looks like travis tests are failing due to PHPUnit_Framework_TestCase which is not working anymore in phpunit 6

Answer 3 · 2020-10-08T09:26:37.000Z

Yes i know, i hadn't the time to update these unittests yet.

Answer 4 · 2020-10-08T09:32:07.000Z

Sure, no problem. Btw I recently fixed this kind of issue in my project by find and replace ;)