Bug: 'Insert' statement turns into 'Select' statement in some scenarios

[sidazhang]

var sql = require('sql')
var model = sql.define({
  name: 'test',
  columns: ['c1', 'c2']
})

console.log(model.insert([]).toQuery())
/*
This should throw an error as I am trying to insert nothing.
Clearly a mistake on the programmer's side

Instead, it fails silently:
-> { text: 'SELECT * FROM "test"', values: [] }

This means that the programmer won't be alerted to the mistake.
Because the query will not throw an error.
*/

This scenario should throw an error and alert the programmer. In any case, it should not turn into a select

[joe-spanning]

👍 This is still an issue.

[Hiteshm01]

This is not a bug, but a feature #203 :)

[joe-spanning]

Harmless? I disagree. What if I have billions of rows in that table? SELECT * is not harmless.

EDIT: Ok, I see issue 203 was to add the WHERE (1=2) clause. We're seeing SELECT * FROM table because our version is really old.

[sidazhang]

This is extremely difficult to debug. Can you explain why isn't the correct behavior to throw an error?

[Hiteshm01]

#197 explains it.
Well, not really - its just backward-compatible behavior. The correct backward-incompatible behavior would be to not generate a query.