brianc/node-sql

Oracle dialect generates wrong syntax for adding a column

Opened this issue · 0 comments

Think this is an easy one. When doing tableDef.alter().addColumn(aColumnDef) the Oracle dialect is generating sql that says "ADD COLUMN" where it should simply say "ADD"

Solution is probably to add this to the oracle dialect right?

Oracle.prototype.visitAddColumn = function(addColumn) {
this._visitingAddColumn = true;
var result = ['ADD ' + this.visit(addColumn.nodes[0])];
this._visitingAddColumn = false;
return result;
};