briandowns/openweathermap

Enhancement: Hourly forecast feature

tejainece opened this issue · 8 comments

Would be nice to have hourly forecast feature.

http://openweathermap.org/forecast5

What should this structure be called?

Forecast3HData?
ForecastHourlyData?
Forecast3HourlyData?

Maybe leave off "Data". I have to check the naming conventions for numbers in function names, otherwise that's great.

You call

  1. Current weather: CurrentWeatherData.
  2. Forecast weather: ForecastWeatherData

So thought maybe we should keep that convention.

Crap, I completely misread that. What you have is perfect. I was thinking those were function names. You're on point. Good stuff. Thanks!

Cool. You have to pick one from those three :)

What are the fields the struct will contain in regards to it's pairing with the response JSON?

Submitted the pull request for InitConfig and hourly forecast.

The structure to be named is in forecast3H.go file. It is currently being called Forecast3HData. let me know if it has to be changed.

Fixing in another release