webkit adapter allows write-only non-string keys

[jimfulton]

The webkit-sqlite adapter allows non-string keys in get requests, but
can't look up the saved objects.

db = new Lawnchair({name: 'xxx'}, function() {})
Lawnchair
db.save({key:'3', a: 1})
Lawnchair
db.get('3', function (o) {console.log(o.key)})
Lawnchair
3
db.save({key:2, a: 1})
Lawnchair
db.get(2, function (o) {console.log(o)})
Lawnchair
null

This is in 0.6.3. I didn't have this problem in 0.5.0.

The dom and memory adapters allow integer keys.

I couldn't find anything in the docs saying that keys had to be
strings.

[timbertson]

I can confirm this, in latest chrome on fedora.
It's also impossible to remove the saved items (they are retrieved by all and each, but can't be removed without a call to nuke).

[paolooo]

I was able to fixed this. Just edit adapters/webkit-sqlite.js

line 5: ( https://github.com/brianleroux/lawnchair/blob/master/src/adapters/webkit-sqlite.js#L5 )
Added the following code:

,   convertInt2String = function(args) {
                // converts array's integer value to string
                return args.map(function(value, index, arr){
                        return '' + value
                });
        }

---

line 66: ( https://github.com/brianleroux/lawnchair/blob/master/src/adapters/webkit-sqlite.js#L44 )
Replaced the following code:
, ins = "INSERT OR REPLACE INTO " + this.record + " (value, timestamp, id) VALUES (?,?,?)"
with:
, ins = "INSERT OR REPLACE INTO " + this.record + " (value, timestamp, id) VALUES (?,?,"

---

line 83: ( https://github.com/brianleroux/lawnchair/blob/master/src/adapters/webkit-sqlite.js#L83 )
t.executeSql(ins, insvals[i])
replace it with:

// Fixed the issue on id field.
// Numeric id will now save as Integer. Otherwise, it will be saved as String.
ins += /\D/.test(insvals[i][2]) ? "'" + insvals[i][2] + "'" : insvals[i][2];
ins += ')';
console.log('sql: ', ins)
t.executeSql(ins, [insvals[i][0], insvals[i][1]])

---

line 101: ( https://github.com/brianleroux/lawnchair/blob/master/src/adapters/webkit-sqlite.js#L101 )
Added the following code:

// converts integer value to string
args = convertInt2String(args);

---

line 152: ( https://github.com/brianleroux/lawnchair/blob/master/src/adapters/webkit-sqlite.js#L152 ) replaced remove function with:

remove: function (keyOrArray, cb) {
        var that = this
        ,   args = this.isArray(keyOrArray) ? keyOrArray : [keyOrArray]
        ,   sql  = "DELETE FROM " + this.record + " WHERE id "
        ,   win  = function () { if (cb) that.lambda(cb).call(that) }

        // converts integer value to string
        args = convertInt2String(args);

        if (!this.isArray(keyOrArray)) {
                sql += '= ?';
        } else {
                sql += "IN (" +
                        args.map(function(){return '?'}).join(',') +
                        ")";
        }

        // converts integer value to string
        args = convertInt2String(args);

        this.db.transaction( function (t) {
                t.executeSql(sql, args, win, fail);
        });

        return this;
},

---

 // Fixed the issue on id field.
 // Numeric id will now save as Integer. Otherwise, it will be saved as String.
ins += /\D/.test(insvals[i][2]) ? "'" + insvals[i][2] + "'" : insvals[i][2];
ins += ')';
t.executeSql(ins, [insvals[i][0], insvals[i][1]])

[basepack]

Is this code fixed in the current branch?

Thanks!