AMD version of the code

Question

AMD version of the code

Opened this issue 8 years ago · 6 comments

hitteshahuja commented 8 years ago

Hi @marxjohnson

I'd like to propose to start looking at the AMD version of JS as Moodle 2..9+ supports it .

Hittesh

nadavkav commented 8 years ago

+1

Answer 1 · 2016-05-25T10:18:20.000Z

Hi Hittesh,
That sounds like a good idea to me. I don't have much time to work on this myself, but I've been doing quite a bit of work with AMD/jQuery in Moodle so if you'd like to bounce any ideas around please let me know. There's a few other minor issues that have been opened/had pull requests recently, so maybe I could address them while you look at the AMD conversion, and we could have a nice new release for 2.9+?

Answer 2 · 2016-05-31T08:49:31.000Z

Hi Mark,
Will try and start working on it this week and keep you updated . I haven't dabbled much with it but i believe its just a matter of "porting" code the AMD way and Moodle should be able to pick it up ? I'll follow through the AMD guidelines on moodle.org

Answer 3 · 2016-06-14T16:03:56.000Z

@marxjohnson Any reason why this isnt a good time to move to Jquery instead of YUI ?

Answer 4 · 2016-06-17T08:14:34.000Z

@hitteshahuja I think moving to jQuery would be good too, for consistency with current best practice.

Answer 5 · 2016-10-11T20:54:09.000Z

Guys,
took me a while but its a bit difficult to devote time to this but I think I am making progress. Finally created an AMD / JQuery version which is under pipeline

https://github.com/hitteshahuja/moodle-block_accessibility/tree/MOODLE_30_STABLE_dev

Agreed this is not the complete solution but I am trying my best to do bits and pieces here and there to complete this ASAP

Any comments / suggestions welcome

Hittesh