brightlayer-ui/themes

Angular Theme doesn't strictly follow Angular guidelines

joebochill opened this issue · 1 comments

Bug or feature request?

Feature Request

What is the expected behavior?

  • Custom themes should work as described in the Angular Material theming guide.
  • Blue theme should not override the default material theme
  • All themes should be identified with a theme class
  • Theme(s) should be included in styles object of angular.json instead of imported into scss file

What is the current behavior?

Blue theme overrides material default. No class for the blue theme. Instructions say to import the file into top-level scss file.

What is your environment?

Framework

  • Angular
  • React

Anything else to add?

This fix will require a major version bump for breaking changes.

This was resolved in our last theme update (2.0.0)