Drop Down menu
piotr-yuxuan opened this issue · 8 comments
Hi guy, thanks a lot fot this beautiful site theme I'm planning to use \o/
Actually this is not really an issue but more a request to extend that theme: could you add drop down menu? :-) I mean, something like this: http://codepen.io/philhoyt/pen/ujHzd
As you say pull requests are welcome, I can try to do it by myself if you tell me which file I should put new code in: I don't feel very comfortable yet with scss.
How many levels of submenu do you want?
Thanks for your reply!
Ha ha, basically the general solution would be « n > 1, with automatic positioning », but actually no, just 1 sublevel will be perfect. If you just give me hint, I can try to do it by myself -- scss is easier to get started with then expected :-)
@piotr-yuxuan I am working on it. But if you want, you can update scss styles in css/styles.scss after line 100, and add sub menu in _includes/header.html .
Ok, I've got a proposal here: https://piotr-yuxuan.github.io/
It's only a proposal because -- you'll very quickly understand why but I'm not that good in CSS and I believe you could correct that bug easily. I've don't either know how to give an automatic width to sub-items. Last remark, it disappears when mobile mode, but I think it's not that bad -- it would take some time to make a proper mobile-adapted sub-menu.
You can notice I put links and your name in he About section, so we know who thie theme comes from ~
I am adding support for single level submenu in my next commit.
great, thanks!
Heya :-) just a short message to know when you'll commit it. As you can see in my proposal, there is something wrong I haven't managed to fix.
unresolved, moving to another theme.