Importing "server.js" from esm.sh fails

Question

Importing "server.js" from esm.sh fails

deckchairlabs opened this issue 2 years ago · 14 comments

Attempting to use this library in a Deno context, with esm.sh new option of specifying external deps. I believe it's failing as there is no esm source specified for the server.js export as the client export works fine, https://esm.sh/react-streaming@0.2.15/client?external=react

https://esm.sh/react-streaming@0.2.15/server?external=react

Answer 1 · 2022-07-19T08:52:29.000Z

Is there a deno exports? That'd be more precise than adding an import exports.

Answer 2 · 2022-07-19T11:38:26.000Z

Looks like esm.sh uses the module condition if it's defined for the export

https://github.com/ije/esm.sh/blob/master/server/build.go#L208

Answer 3 · 2022-07-19T13:22:23.000Z

So there is no ‘exports’ field for targeting deno specifically? The thing is that the ESM modules living at ‘dist/esm/’ only work for the browser (and probably Deno) but don’t for Node.js — Node.js will fail if it attempts to load any module living there. So we should opt out Node.js if possible.

…

On Tue 19. Jul 2022 at 13:38, James Edmonds ***@***.***> wrote: Looks like esm.sh uses the module condition if it's defined for the export https://github.com/ije/esm.sh/blob/master/server/build.go#L208 — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHVQRXQBWGWCAQUFXVLKETVU2HTZANCNFSM536HFSOQ> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 4 · 2022-07-21T03:55:18.000Z

I suppose a better option would be to possibly publish a deno compatible version to https://deno.land/x

Answer 5 · 2022-07-21T10:58:38.000Z

Is there a way to automatically publish to deno.land/x when running npm publish?

Answer 6 · 2022-07-21T12:49:35.000Z

deno.land publish is based on git tags. https://muffinman.io/blog/add-git-version-tag-after-publishing-to-npm/#tl-dr

Answer 7 · 2022-07-21T21:03:50.000Z

Neat.

I just re-published 0.2.15, as 0.2.16 with a tag https://github.com/brillout/react-streaming/tags.

Is there anything else that needs to be done? (PR welcome if that's something you'd be up for.)

Answer 8 · 2022-07-22T07:38:52.000Z

I'm just seeing https://deno.land/add_module.

So I guess it wants the source files and not dist/, i.e. the src/ directory as "Subdirectory". Does it work with TypeScript Node.js source files? E.g. when importing npm packages, will it work?

Answer 9 · 2022-07-22T07:49:48.000Z

Here we are: https://deno.land/x/react_streaming@v0.2.17. Let me know if it works, it's the src/ directory, I'm not sure if that's what Deno wants.

FYI 8342ebb.

Answer 10 · 2022-07-22T08:59:52.000Z

It's going to need a separate output unfortunately. Deno requires the file extensions in the import specifier.

I know latest typescript now supports this? And can output the relevant code etc

Answer 11 · 2022-07-22T09:03:50.000Z

PR welcome

Answer 12 · 2022-07-22T09:26:28.000Z

Actually, I don't think we should complexify the build process (just because Deno stubbornly doesn't want to interop with Node.js).

Let's try with esm.sh first, ideally with esm-dev/esm.sh#376, but we can try import in the meantime and see if Node.js will be ok with that.

PR welcome to add the import field in a way that works with Node.js.

Answer 13 · 2022-07-26T11:19:51.000Z

esm.sh actually does support the deno export field: esm-dev/esm.sh#376 (comment).

Which I just added 4b5c6b2, so I guess we're good?

Answer 14 · 2022-07-26T18:16:45.000Z

Released in 0.2.18.