brillout/telefunc

Remove node:path and process.nextTick dependency

Closed this issue · 7 comments

nitedani commented

Remove node:path and process.nextTick dependency to support edge runtimes.
Here is a working example running on vercel edge:
https://hono-react-nitedani-nitedanis-projects.vercel.app/dynamic?_vercel_share=iFkEgX1gF9U1hM806vEBdiywntbfo7CA
All I had to do:

  • replace path.join(a,b) with a + "/" + b - of course this is just for showcase
  • comment out asserts depending on path
  • replace process.nextTick with setTimeout
brillout commented

All I had to do:

  • replace path.join(a,b) with a + "/" + b - of course this is just for showcase
  • comment out asserts depending on path
  • replace process.nextTick with setTimeout

Do you still have that diff somewhere?

samuba commented

Second this! Currently cloudflare throws"Error: Dynamic require of \"node:path\" is not supported" during runtime even with node compat mode enabled.

  • 👍1
brillout commented

@samuba Up for a PR? Should be relatively easy.

samuba commented

@brillout I would be up for it. Would use the path drop in replacement https://github.com/unjs/pathe though, as I see there is more then just path joining involved.
You probably want to keep the runtime code dependency free, so I would drop the 3 file from pathe into the src. What do you think?

brillout commented

How about we start with the pathe npm package at first and in a minimal fashion (i.e. only using for the runtime and not for the Vite plugin). Let's then see whether we can remove or trim down pathe.

samuba commented

PR: #126
had to replace usage of path.posix.* with path.* as pathe does not provide that api

brillout commented

telefunc@0.1.82 the server runtime shouldn't depend on Node.js anymore (I didn't test it though so let me know if there's still a Node.js dependency somewhere).