Remove requireDefaultRecords population of report
Closed this issue · 1 comments
robbieaverill commented
The fact that Package::requireDefaultRecords
runs the full task, in combination with the fact that we're now including the silverstripe-composer-update-checker logic as a callback inside this task, means that it adds a relatively large amount of time to a dev/build run. It can also max out the default PHP memory limit for some users at 128mb.
My suggestion would be NOT to use requireDefaultRecords for this, and rely on users either manually generating the report in the CMS or via build task, or letting a cron do it via queued jobs.
If we're creating a record with this approach I think it should be queuing a job rather than executing it immediately.
robbieaverill commented
PR at #91