brminnick/GitTrends

Issue changed to discussion gives error

VincentH-Net opened this issue · 8 comments

Issue 119 in the MAUI repo was recently changed to a discussion:

dotnet/maui#119

If you paste this issue url in the browser, the discussion is shown.

But if you open this blog post:

https://devblogs.microsoft.com/xamarin/c-sharp-markup-for-xamarin-forms/

And then at the end of the post tap on the "C# Markup for MVU and MVVM" link to that issue, GitTrends opens with a cannot resolve error.

Best would be to fix it, but as a fallback maybe add a clickable hyperlink in this type of error pages, to open the url in the browser? Then it's no longer a dead end

PS The above link is present in many places, would really appreciate a quick fix

Hey @VincentH-Net!

I'm a bit confused - Is this a problem in GitTrends?

Well, the link works if you pasye it in the browser address bar, but if you have gittrends installed it will automatically open when you tap on the link (on android anyway) and then fail, which effetively breaks the link for anyone who has gittrends installed on their phone.

Anyway I supplied repro info so it should be straightforward to find out what is happening.

Do you support discussions? The wording of the error says "issue or pull request" .

Where is the link? Is this a link in the GitTrends repo?

Link is in many web pages. The issue description gives an example repro where the link is in a blog post:

if you open this blog post:
https://devblogs.microsoft.com/xamarin/c-sharp-markup-for-xamarin-forms/

And then at the end of the post tap on the "C# Markup for MVU and MVVM" link to that issue, GitTrends opens with a cannot resolve error.

Yes, I read those steps the initial writeup and am unable to reproduce the error.

Could you share more-specific reproduction steps and/or a screen capture?

Here are my screen captures showing that the C# Markup for MVU and MVVM link opens in the browser as expected:

Mobile (iOS Safari) Desktop (macOS Safari)
ScreenFlow2 ScreenFlow

My repro is on Android 9, Galaxy S8:
In chrome:
Screenshot_20200723-212432_Chrome.jpg

After tapping on the link:

Screenshot_20200723-212445_GitHub.jpg

Thanks Vincent!

I confirmed on Android that the link opens the GitHub mobile app, not GitTrends.

Screenshot_20200723-133710
Screenshot_20200723-133851

Oops, my bad.
I should have known that an app created fully in C# could not contain such an obvious bug ;-)