brminnick/GitTrends

List organisation repositories

wischi-chr opened this issue · 9 comments

Is your feature request related to a problem? Please describe.
Kind of. I just tried the app (on android) and also granted access to some organisations, but sadly the organisation repos don't show up.

Describe the solution you'd like
If during the oauth grant the user grants access to one or more organisations, the repositories from those organisations should also be listed.

Describe alternatives you've considered
None. Not sure if there are any.

Additional context
Android App (v.2.0.3)

Thanks for the feedback!

Question - In the GitHub web portal, can you confirm that you have access to the Insights tab for the missing repos? (example below)

The way GitHub's permissions work, you must have Collaborator access to a repo to view its Insights.

If you do have access to the Insights tab, then your repository should certainly appear in GitTrends and this is 100% a bug in the app. But if you don't have access to the Insights tab, GitTrends won't be able to retrieve the Insights for a repo if you're not a Collaborator.

Screen Shot 2021-02-14 at 2 13 25 PM

Screen Shot 2021-02-14 at 2 13 52 PM

Yes, I have access to that.
For example screenshot for OpenMacroBoard/StreamDeckSharp

image

Thanks @wischi-chr!

Sounds like a bug.

Just to ensure we're on the same page, can you confirm the following are true?

  • OpenMacroBoard does not appear on your Repositories list
  • You granted Organization access to OpenMacroBoard when connecting GitTrends to your GitHub Account (screen shot example)
    Simulator Screen Shot - iPhone 12 - 2021-02-23 at 10 16 56

Closing until more information is provided

flish commented

HI Brandon, just to let you know I'm seeing the same issue on the iOS version, I gave organisation access (I am in two, of which at least one has a public repo that I am an admin on on), but I can only see my @flish public repos in the app - anything I can do to assist debugging?

Thanks @flish! Reopening to continue the investigation.

Can you confirm that, in your GitHub Developer Settings, that you have granted organization access to the GitTrends OAuth app?

Here's the steps to confirm that:

  1. On GitHub.com, select your profile picture
  2. In the profile drop-down, select Settings

Screen Shot 2021-04-08 at 10 38 15 AM

  1. On the Settings page, select Applications
  2. In the Aplications window, at the top tabbar, select Authorized OAuth Apps
  3. In the Authorized OAuth Apps tab, select GitTrends

Screen Shot 2021-04-08 at 10 46 34 AM

  1. In the GitTrends window, in the Organization access frame, confirm organization access has been granted

Screen Shot 2021-04-08 at 10 43 15 AM

Note: In the above screenshot, my Organization access says Request. Yours should say Granted

flish commented

Confirmed, both orgs in my profile have access, see below;

image

Can confirm that I'm experiencing the same issue, the organization displays in the "Organization access" but the "Repositories" list in the app is empty.

Screenshot 2021-04-15 at 12 11 23

Thanks all for confirming!

I'll dig into the GitHub APIs / OAuth flows to figure out a fix.

I can't jump on this bug fix right away, so I've also added the Help Wanted tag in case anyone is able to help out! Even linking to a GitHub Doc on how to implement it would be super helpful!

(I've also hidden some of the previous screenshots to streamline the conversation and make it a bit more readable for other folks who come across this to easily catch up)