brminnick/GitTrends

v2.1.0 Translations

brminnick opened this issue · 4 comments

brminnick commented

Describe the bug

The following RESX files are incomplete for the v2.1.0 release:

  • AboutPageConstants.bs.resx
  • AboutPageConstants.de.resx
  • AboutPageConstants.en.resx
  • AboutPageConstants.es.resx
  • AboutPageConstants.fr.resx
  • AboutPageConstants.nl.resx
  • AboutPageConstants.pt.resx
  • AboutPageConstants.ru.resx
  • AboutPageConstants.uk.resx
  • RepositoryPage.bs.resx
  • RepositoryPage.de.resx
  • RepositoryPage.en.resx
  • RepositoryPage.es.resx
  • RepositoryPage.fr.resx
  • RepositoryPage.nl.resx
  • RepositoryPage.pt.resx
  • RepositoryPage.ru.resx
  • RepositoryPage.uk.resx

Expected behavior

The Unit Tests for ResxTests should pass

Actual Behavior

The Unit Tests for ResxTests throw the following errors

ConfirmTranslationsAreComplete(AboutPageConstants)

  Missing Data Found
  Expected: <empty>
  But was:  < <bs
	AboutPageConstants [ LibrariesTitle : Libraries ]
	AboutPageConstants [ Watching : Watching ]
	AboutPageConstants [ GitHubButton : View on GitHub ]
	AboutPageConstants [ Forks : Forks ]
	AboutPageConstants [ Stars : Stars ]
	AboutPageConstants [ CollaboratorsTitle : Collaborators ]
	AboutPageConstants [ DescriptionText : GitTrends is an open-source app built in C# using Xamarin.Forms that helps you monitor your GitHub repositories! ]
	AboutPageConstants [ RequestFeatureButton : Request Feature ]
	AboutPageConstants [ CollaboratorsDescription : Thank You to all of our amazing open-source contributors. Tap on a contributor to learn more! ]
	AboutPageConstants [ LibrariesDescription : Thank you to all of the amazing libraries and frameworks that made GitTrends possible! ]
>, <de
	AboutPageConstants [ LibrariesTitle : Libraries ]
	AboutPageConstants [ Watching : Watching ]
	AboutPageConstants [ GitHubButton : View on GitHub ]
	AboutPageConstants [ Forks : Forks ]
	AboutPageConstants [ Stars : Stars ]
	AboutPageConstants [ CollaboratorsTitle : Collaborators ]
	AboutPageConstants [ DescriptionText : GitTrends is an open-source app built in C# using Xamarin.Forms that helps you monitor your GitHub repositories! ]
	AboutPageConstants [ RequestFeatureButton : Request Feature ]
	AboutPageConstants [ CollaboratorsDescription : Thank You to all of our amazing open-source contributors. Tap on a contributor to learn more! ]
	AboutPageConstants [ LibrariesDescription : Thank you to all of the amazing libraries and frameworks that made GitTrends possible! ]
>, <fr
	AboutPageConstants [ LibrariesTitle : Libraries ]
	AboutPageConstants [ Watching : Watching ]
	AboutPageConstants [ GitHubButton : View on GitHub ]
	AboutPageConstants [ Forks : Forks ]
	AboutPageConstants [ Stars : Stars ]
	AboutPageConstants [ CollaboratorsTitle : Collaborators ]
	AboutPageConstants [ DescriptionText : GitTrends is an open-source app built in C# using Xamarin.Forms that helps you monitor your GitHub repositories! ]
	AboutPageConstants [ RequestFeatureButton : Request Feature ]
	AboutPageConstants [ CollaboratorsDescription : Thank You to all of our amazing open-source contributors. Tap on a contributor to learn more! ]
	AboutPageConstants [ LibrariesDescription : Thank you to all of the amazing libraries and frameworks that made GitTrends possible! ]
>, <nl
	AboutPageConstants [ LibrariesTitle : Libraries ]
	AboutPageConstants [ Watching : Watching ]
	AboutPageConstants [ GitHubButton : View on GitHub ]
	AboutPageConstants [ Forks : Forks ]
	AboutPageConstants [ Stars : Stars ]
	AboutPageConstants [ CollaboratorsTitle : Collaborators ]
	AboutPageConstants [ DescriptionText : GitTrends is an open-source app built in C# using Xamarin.Forms that helps you monitor your GitHub repositories! ]
	AboutPageConstants [ RequestFeatureButton : Request Feature ]
	AboutPageConstants [ CollaboratorsDescription : Thank You to all of our amazing open-source contributors. Tap on a contributor to learn more! ]
	AboutPageConstants [ LibrariesDescription : Thank you to all of the amazing libraries and frameworks that made GitTrends possible! ]
>, <pt
	AboutPageConstants [ LibrariesTitle : Libraries ]
	AboutPageConstants [ Watching : Watching ]
	AboutPageConstants [ GitHubButton : View on GitHub ]
	AboutPageConstants [ Forks : Forks ]
	AboutPageConstants [ Stars : Stars ]
	AboutPageConstants [ CollaboratorsTitle : Collaborators ]
	AboutPageConstants [ DescriptionText : GitTrends is an open-source app built in C# using Xamarin.Forms that helps you monitor your GitHub repositories! ]
	AboutPageConstants [ RequestFeatureButton : Request Feature ]
	AboutPageConstants [ CollaboratorsDescription : Thank You to all of our amazing open-source contributors. Tap on a contributor to learn more! ]
	AboutPageConstants [ LibrariesDescription : Thank you to all of the amazing libraries and frameworks that made GitTrends possible! ]
>, <ru
	AboutPageConstants [ LibrariesTitle : Libraries ]
	AboutPageConstants [ Watching : Watching ]
	AboutPageConstants [ GitHubButton : View on GitHub ]
	AboutPageConstants [ Forks : Forks ]
	AboutPageConstants [ Stars : Stars ]
	AboutPageConstants [ CollaboratorsTitle : Collaborators ]
	AboutPageConstants [ DescriptionText : GitTrends is an open-source app built in C# using Xamarin.Forms that helps you monitor your GitHub repositories! ]
	AboutPageConstants [ RequestFeatureButton : Request Feature ]
	AboutPageConstants [ CollaboratorsDescription : Thank You to all of our amazing open-source contributors. Tap on a contributor to learn more! ]
	AboutPageConstants [ LibrariesDescription : Thank you to all of the amazing libraries and frameworks that made GitTrends possible! ]
>, <uk
	AboutPageConstants [ LibrariesTitle : Libraries ]
	AboutPageConstants [ Watching : Watching ]
	AboutPageConstants [ GitHubButton : View on GitHub ]
	AboutPageConstants [ Forks : Forks ]
	AboutPageConstants [ Stars : Stars ]
	AboutPageConstants [ CollaboratorsTitle : Collaborators ]
	AboutPageConstants [ DescriptionText : GitTrends is an open-source app built in C# using Xamarin.Forms that helps you monitor your GitHub repositories! ]
	AboutPageConstants [ RequestFeatureButton : Request Feature ]
	AboutPageConstants [ CollaboratorsDescription : Thank You to all of our amazing open-source contributors. Tap on a contributor to learn more! ]
	AboutPageConstants [ LibrariesDescription : Thank you to all of the amazing libraries and frameworks that made GitTrends possible! ]
> >

ConfirmTranslationsAreComplete(RepositoryPageConstants)

  Missing Data Found
  Expected: <empty>
  But was:  < <bs
	RepositoryPageConstants [ TOTAL : TOTAL ]
>, <de
	RepositoryPageConstants [ TOTAL : TOTAL ]
>, <nl
	RepositoryPageConstants [ TOTAL : TOTAL ]
>, <pt
	RepositoryPageConstants [ TOTAL : TOTAL ]
>, <ru
	RepositoryPageConstants [ TOTAL : TOTAL ]
>, <uk
	RepositoryPageConstants [ TOTAL : TOTAL ]
> >
Alex-451 commented

@brminnick I could create a german translation, should i open a ticket or is someone already working on that?

brminnick commented

Thanks @AlexGipp!

@lothrop actually beat you to it! I merged his PR this morning: #234

Alex-451 commented

Okay, thanks for getting back to me though!

bricefriha commented

@brminnick I'm currently working on the french translation of the about page 😉

  • ❤️1