broadinstitute/ml4h

Date time format in defines, not hard-coded in _cardiac_surgery_str2date

erikr opened this issue · 0 comments

erikr commented

What
Each TMap should be able to specify the date time formatting in https://github.com/broadinstitute/ml/blob/22f5c9efe5522d084339c7e6f414737688bff397/ml4cvd/tensor_maps_partners_ecg.py#L1756-L1757.

Why
Unfortunately datetimes in files generated by our clinical collaborators do not always follow "%d%b%Y".

TMaps are the appropriate place to specify the formatting and override defaults.

How
_cardiac_surgery_str2date accepts an argument date_format, which a TMap can set.

Acceptance Criteria
TMap can set date time formatting for _cardiac_surgery_str2date.