Replace usages of `Client.get_object` by `Client.request`
browniebroke opened this issue · 2 comments
Most of the client methods use the get_object
method internally:
deezer-python/deezer/client.py
Lines 156 to 174 in 59b0f57
In #379, the request
method was added:
deezer-python/deezer/client.py
Lines 129 to 154 in 59b0f57
They are very similar, but the request
method is more versatile, we should aim to migrate all usages to the latter and eventually delete the get_object
method.
Hi, can I take this issue?
Feel free to take it, yes. It might involve a good amount of repetitive changes.
Also, I realised that the 2 methods raise a slightly different exception in case of error so this would be a breaking change that will require a major version bump. We need to mark this change as such as explained in the conventioanl commits spec.