Recurring message every minute when minute is 0

Question

Recurring message every minute when minute is 0

Closed this issue 5 years ago · 1 comments

When the minute is 0, the scheduled rule has null for minute causing it to send every minute. Possibly caused by 0 being nullish in the null propagation operator. ?. is also not the most supported operator, may want to reconsider it's use.

Answer 1 · 2020-04-28T18:13:00.000Z

I believe if we remove the ternary operator on these lines it will fix this issue. As the comment suggests, they should be defaulted to null and shouldn't require this operator. The ternary operator also checks for falsey values, which includes 0.
https://github.com/brrcrites/twilio-dev-hack/blob/33c0f088485a886f38b4195cdd1082571131cfd2/server/app/RecurringJob.js#L127-L130