bruderstein/react-render-hook

Submodule react-devtools error

Closed this issue · 5 comments

xlarsx commented

Hi good day,
Since today when we update our dependencies we found some errors when testing the system:

 TypeError: Cannot read property 'displayName' of undefined

And it seems that is because some validation that is missing in the react-devtools, we just post the pull request but meanwhile is accepted the system is failing... could you please help us to revert the git submodule?

Thanks for your support! Greetings,

bruderstein commented

How are you creating an undefined component? That shouldn't really be possible... It's more likely there's an issue in this project, or somewhere in the unexpected-react stack that causes this.

diazod commented

@bruderstein for what I have investigated this is the commit causing the issue

facebook/react-devtools@7efca36

bruderstein commented

That is exactly the commit we need in order to see rendered 0 (take a look at a react component that renders <div>Hello {0}</div> - you'll see <div>Hello </></div> in the devtools, and it breaks unexpected-react.

I still don't understand how you're arriving at the issue you're getting. Would it be possible to create a mini-repro? Or describe at least how you are creating (or what you mean by) an "undefined" component.

diazod commented

@bruderstein We found the issue; apparently we were trying to render an empty string value which in old version was a falsy value.
Sorry for the inconvinience

xlarsx commented

Thank you very much.

Greetings,