brummer10/neural-amp-modeler-ui

Long file name.

rusk911 opened this issue · 15 comments

Is it possible to crop long file names an display full name in tooltips?
Screenshot at 2024-01-31 10-04-01

Hi
Yes, I've pushed a fix for it to the repository now. long file names will be coped now and the tooltip will appear on the file browser button.

Hi Yes, I've pushed a fix for it to the repository now. long file names will be coped now and the tooltip will appear on the file browser button.

strange. pulled changes, rebuilt and reinstalled but see no changes in gui. Tooltip is present, but file name still overlaps browse button.
Screenshot at 2024-01-31 12-18-14

That's really strange. Is that a Hdpi monitor?
However, it crop the filename now even more with the last commit, so that it should fit in the filename display part. Please pull and reinstall again.

No. 1680x1050 old LCD.

Now it looks better, but still not ideal
Screenshot at 2024-01-31 14-51-43

Which set is that? Seems I need to check that one to find out what goes wrong here.
All sets I tested so far crop correctly. My impression is that "numbers" wouldn't be correctly handled by my crop function.

Most NAM model files I downloaded contains some hash and capture parameters. For example this: 2555SL-P6.5-B5-M6-T6.5-OM6-LM7-G7-GE7-c4111ae17efbd50382b3b7abfdfc004c.nam
you can just rename any existing nam file for testing I guess.

Yep. I see now. I'll investigate.
Thanks for the hint.

Okay, got it. There was a error in my calculation.
Should be fixed now really. (Fingers cross :) )

Yes. Much better now. Last 2 dots still are out of frame but it's not a big issue. I still have some notice about usability, but I guess it's not for this repository. Every time I open file browser I have to switch to list view. Non-ui version opened last used setting. Same for all system dialogs (Linux Mint). First time I navigate to NAM files location it shows subfolders, next time I open a file browser it shows only NAM files with no subfolders. I beleave better delegate this function to system-wide file dialogue or host used, but not implement own file browser.
Screenshot at 2024-01-31 15-30-34

Okay, the file browser don't show subfolders is a bug. I've fixed that now.
For the list view that will become a bit tricky (but doable), as a plugin didn't save any system wide options anywhere. Hosts, or system file browsers have that option.
I'll check that tomorrow, thanks for the suggestion.

the file browser don't show subfolders is a bug. I've fixed that now.

Still not fixed. After loading a nam file from a folder with mixed subfolders and nam files it still shows only files, but no subfolders. I have to navigate again to the location to see them.
Screenshot at 2024-02-01 10-58-51

Oh, sorry, my bad. I forgot to update submodules. Confirm, subfolders issue is fixed. Thank you! Great job!

When you now do a pull again (including submodule update) you'll get the "store the list view and size" as well. True, we could only store the state during session, but I guess that's already helps.
I've as well reworked the crop function a bit, hopefully it will crop the filename now so that it fit completely into the space.

Thanks for your suggestions.

Yes, great. Everything is working now. Thank you!