Layout optimizations
es128 opened this issue · 12 comments
Compare page layout is awkward currently. Either drop the tweets from that page, or allow the grid to fit to the left of them on wide viewports.
Edit: Other needed modifications discussed in comments below
also skeletons
Skeletons actually seems like it needs the opposite.
Or a new template that drops the tweets box from both these pages is also probably a good solution.
we also need a viewport setting that will hide tweets box on mobiles, it is not needed there and doesn't fit the screen
Done. Anything else?
Left the tweets on Home & Support, on mobile they move to the bottom instead of pushing the content down. They could be hidden as you suggested, but I think this is ok.
👍
http://brunch.io 404
@es128 actually, can you please make tweets bar hidden on mobiles? I used float: right on purpose, I wanted star / tweet buttons to be shown on mobiles on top too
Sorry about the CNAME thing, I didn't touch it deliberately. Just brunch b -P, then the grunt task. I checked the live site after pushing and it worked - DNS caching I guess? We should fix whichever process is killing the CNAME file.
Don't totally understand your last comment. You want them hidden or on top for mobiles?
on desktop: all buttons and stuff is like now
on mobile: all buttons are on top (not bottom), tweets list is hidden
Got it. I can take care of that.
Done. Plus improved responsive header and hero block.