brunocodutra/reducer

RUSTSEC-2021-0119: Out-of-bounds write in nix::unistd::getgrouplist

Closed this issue · 1 comments

Out-of-bounds write in nix::unistd::getgrouplist

Details
Package nix
Version 0.20.0
URL nix-rust/nix#1541
Date 2021-09-27
Patched versions ^0.20.2,^0.21.2,^0.22.2,>=0.23.0
Unaffected versions <0.16.0

On certain platforms, if a user has more than 16 groups, the
nix::unistd::getgrouplist function will call the libc getgrouplist
function with a length parameter greater than the size of the buffer it
provides, resulting in an out-of-bounds write and memory corruption.

The libc getgrouplist function takes an in/out parameter ngroups
specifying the size of the group buffer. When the buffer is too small to
hold all of the reqested user's group memberships, some libc
implementations, including glibc and Solaris libc, will modify ngroups
to indicate the actual number of groups for the user, in addition to
returning an error. The version of nix::unistd::getgrouplist in nix
0.16.0 and up will resize the buffer to twice its size, but will not
read or modify the ngroups variable. Thus, if the user has more than
twice as many groups as the initial buffer size of 8, the next call to
getgrouplist will then write past the end of the buffer.

The issue would require editing /etc/groups to exploit, which is usually
only editable by the root user.

See advisory page for additional details.

nix is a dev-dependency used in examples only

cargo tree --invert nix:0.20.0
nix v0.20.0
├── wayland-client v0.28.6
│   ├── glutin v0.25.1
│   │   └── glium v0.28.0
│   │       └── conrod_glium v0.74.0
│   │           [dev-dependencies]
│   │           └── reducer v3.0.0 (/home/bruno/Projects/rust/reducer)
│   │       [dev-dependencies]
│   │       └── reducer v3.0.0 (/home/bruno/Projects/rust/reducer)
│   ├── smithay-client-toolkit v0.12.3
│   │   └── winit v0.23.0
│   │       └── glutin v0.25.1 (*)
│   │       [dev-dependencies]
│   │       └── reducer v3.0.0 (/home/bruno/Projects/rust/reducer)
│   ├── wayland-cursor v0.28.6
│   │   └── smithay-client-toolkit v0.12.3 (*)
│   ├── wayland-egl v0.28.6
│   │   └── glutin v0.25.1 (*)
│   ├── wayland-protocols v0.28.6
│   │   └── smithay-client-toolkit v0.12.3 (*)
│   └── winit v0.23.0 (*)
├── wayland-commons v0.28.6
│   ├── wayland-client v0.28.6 (*)
│   └── wayland-protocols v0.28.6 (*)
└── wayland-cursor v0.28.6 (*)