brusselopole/Worldopole

Pokemon without IV on livemap(100%)

Opened this issue · 5 comments

pki0 commented

Bug:

Pokemon without IV are on the live maps even if you set slider to 100%

Maybe fixable in #275 .

aru.php function maybe needs a rewrite because of this bug and freeze with #275

It is not that easy unless we create a new variable configuration, as there is no easy way to know if the poke or instance has the encounter activated.
To avoid this all pokes without encounter info are shown right now.
The best solution I can think of is using the same configuration as encounter in RM and use that info in ARU to correctly filter pokes.

pki0 commented

Hmm what about:

Slider at minIV = 80%:

Mysql:
SELECT * FROM pokemon WHERE ... HAVING IV > minIV

Slider at 0%

Mysql:
SELECT * FROM pokemon WHERE ... HAVING IV > minIV OR NULL

PHP:
if (!data->iv){
iv = 0
}

This should display failed/non encounters at minIV = 0

pki0 commented

And with changing this we can only ask live pokemon in the rectangle we have zoomed the map. Should work.

The problem with that solution is that changing the IV bar for any poke specie that it is not encountered will hide everything, and we will need to update the default minIV to 0.
Another option is doing a query to check if there is any poke with IV and use that as a switch to hide the IV select bar and change the request to aru to use one query of the other.

After checking the source for another thing I did found that there is already such test (only filter by IV where there are IVs stored) so there is no problem in doing that a proper query where null = 0.

Also I think it will be great that the same check could be used to hide the filter bar in the frontend when there are not IV stored.