brutella/hap

accessory pair failed if name is unicode

zeropool opened this issue · 4 comments

zeropool commented 
nas := accessory.NewSwitch(accessory.Info{
		Name:         "服务器",
		SerialNumber: "052AC-26AAM3",
		Manufacturer: "Apple",
		Model:        "AB",
	})

iphone will stuck when add accessory name use unicode unless the name is ascii charset

joeshaw commented

There are similar bugs in hc. (I haven't verified if they're still issues in hap but I'm guessing they might be)

brutella/hc#192
brutella/hc#195

0x5e commented

Same on me. there's a 400 bad request from hap server, I got it from wireshark, said malformed data or something, but I can't reproduce it now...

And the name will be used in domain, "服务器._hap._tcp.local" that might be related.

0x5e commented

https://github.com/brutella/hap/blob/4ea1de40019c8a72bf7096d8842120ed581038ec/server.go#L489C45-L489C45
Currently the project only handles the whitespaces and latin characters.

brutella commented

Happy to accept any pull request which fixes this issue. 😉