Can't Exclude Texas Holiday (Juneteenth)
Closed this issue · 4 comments
Before you submit a new bug report, please check that
- I have read frequently asked questions and limitations
- I'm running the newest version of Holidays, or the next pre-release.
- I have enabled debug logging for my installation.
Describe the bug
When I add a calendar for US and TX subdivision, if I select 'Emancipation Day In Texas; Juneteenth National Independence Day' to be ignored it is not ignored. All other "Texas" Holidays can be ignored.
If I choose another subdivision (or none at all) the holiday shows as simply 'Juneteenth National Independence Day' and it successfully can be excluded. Only in the case of the combined holiday does it fail.
Configuration
Hitting this button does nothing in my installation for some reason. I am merely setting up a Holiday Calendar using US and TX and attempting to exclude the Juneteenth Holiday.Debug logs
This error originated from a custom integration.
Logger: custom_components.holidays.calendar
Source: custom_components/holidays/calendar.py:273
Integration: Holidays (documentation, issues)
First occurred: 5:58:34 PM (1 occurrences)
Last logged: 5:58:34 PM
(Texas Test) Holiday not removed ('Emancipation Day In Texas; Juneteenth National Independence Day')I am updating the dependency on the holidays package to the same as what Home Assistant uses for workday. Not sure if that helps - they had an issue with this but that was fixed in version 0.11.2, and this integration was already using a newer version.
This seems to be an issue in the holidays library, at some point they changed the concatenated holiday to be separated with ; instead of , :
using python3.6/holidays 0.11.3.1:
python 3.10/holidays .25 (though HA is using .21 I think):
created issue at the python-holidays github:
This issue has been automatically marked as stale because it has not had any activity in last 30 days. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.