bryanpkc/corkscrew

Corkscrew install from brew has broken Proxy-Authorization

Opened this issue · 3 comments

louisbuchbinder commented

Steps to reproduce:

  • Install corkscrew using brew brew install corkscrew
  • Create auth file echo user@pass > auth
  • Make corkscrew request: corkscrew localhost 8000 localhost 8001 auth
  • Header come through like: Proxy-Authorization: Basic Q09OTkVDVCBsb2NhbGhvc3Q6ODAwMSBIVFRQLzEuMApQcm94eS1BdXRob3JpemF0aW9uOiBCYXNpYyA=
  • Decoding the auth header:
base64 --decode <<< 'Q09OTkVDVCBsb2NhbGhvc3Q6ODAwMSBIVFRQLzEuMApQcm94eS1BdXRob3JpemF0aW9uOiBCYXNpYyA='
CONNECT localhost:8001 HTTP/1.0
Proxy-Authorization: Basic

Notes

  • It seems like the request headers themselves are being base64 encoded instead of the contents of the auth file.
  • I built corkscrew from source and the auth works as expected. Possibly this is as simple as publishing the latest corkscrew to homebrew.
corkscrew --version
corkscrew 2.0 (agroman@agroman.net)

Thank you this is very useful software for me.

louisbuchbinder commented

Just created a pull request with updates to the readme for building on macOS. Just a couple pre-install steps and building from source works like a charm.

  • 👍1
louisbuchbinder commented

pr is here: #11

ChrisHardie commented

Confirming that on macOS 14.2.1 with Homebrew 4.2.5, the brew-installed version of corkscrew did not handle proxy authentication (proxy server essentially saw no auth attempt), but when built from source it worked fine.