bryik/aframe-controller-cursor-component

crashes scene

sirkitree opened this issue · 5 comments

Hi there,

I'm trying to use this component in a scene but each time I add the vive-cursor attribute, it crashes the scene.

I'm using the latest master aframe and the latest of this component as well. Here's a codepen to see what's happening: http://codepen.io/sirkitree/pen/aBqQab?editors=1000 - if you modify that scene by just adding the vive-cursor attribute to the vive-control entity, you'll see it crash.

You can't see the error on codepen's console, but here is what I get locally:
tugboat vr - chromium 2016-12-04 08 47 49

Any thoughts on what I might try to get to the bottom of this?

bryik commented

My guess is that a change (probably with the raycaster) has broken vive-cursor in the latest A-Frame master build.

Curiously, adding A-Frame's own raycaster component to the vive-control entity causes the same crash, so the problem may not lie entirely with vive-cursor.

bryik commented

I believe this issue was fixed with the release of A-Frame 0.4.0.

Applying the vive-cursor component to a vive-control entity no longer causes a crash in your CodePen (I just tried it now).

noerw commented

It has a different issue with aframe 0.4.0, saying

TypeError: attributes.position is undefined

could this be related to aframevr/aframe#1925, which was merged for 0.4.0 ?

bryik commented

@noerw Could you file a new issue with more info? I'm not sure how to reproduce that error.

noerw commented

this only occured with this aframe build.
current aframe master works again, nevermind!