require conflict in Lumen 5.6
Closed this issue · 4 comments
Hi，I met some problem when i run "composer require bschmitt/laravel-amqp" in Lumen 5.6, such as following text:
`Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for tightenco/collect (locked at v5.6.24) -> satisfiable by tightenco/collect[v5.6.24].
- bschmitt/laravel-amqp 2.0.0 requires illuminate/support v5.5.28 -> satisfiable by illuminate/support[v5.5.28].
- bschmitt/laravel-amqp 2.0.1 requires illuminate/support v5.5.28 -> satisfiable by illuminate/support[v5.5.28].
- Conclusion: don't install illuminate/support v5.5.28
- Installation request for bschmitt/laravel-amqp ^2.0 -> satisfiable by bschmitt/laravel-amqp[2.0.0, 2.0.1].
Installation failed, reverting ./composer.json to its original content.`
then i found your project require "illuminate/support": "v5.5.28", and Lumen 5.6 require "illuminate/support": "5.6.*",so any suggestion? thanks!
Hey,
5.6 only supports php 7.1 upwards, which is pretty bad for people still on 5.5 which is >=7.0
So either a full upgrade or seperate branches for laravel 5.5 and 5.6 which then supports lumen 5.6 also.
Suggestion as a quicker solution for you: Fork this repository, do branch for 5.6 and upgrade the illuminate/support version. Test it. If it works make a pull request for this main repository.
@stevenklar I gave this a shot. I've forked this repo, updated composer.json to point to a current version of illuminate/support:
"illuminate/support": "v5.6.24"
And I've managed to install it in a fresh lumen 5.6.* from a branch on a fork.
Any other things I have to check for?
I can make a pull request but if it can't be merged I can add a line or two to the docs.
@mirkojotic Awesome!
If everything works as expected we might want to use Version ">5.5" which allows laravel 5.5 and 5.6 users to use this package!
Do you recognize any problems?
Should be fixed with the latest release.