bserdar/jcliff

Getting WFLYJCA0093 when adding datasource

Opened this issue · 2 comments

First of all, let me thank you for this great tool!

I just started with it and I'm adding an XA datasource.

Using JBoss EAP 7.3.5, I get a lot of warnings, whenever the datasource is disabled/enabled:

xa-data-source disable --name=MyName
:reload
/subsystem=datasources/xa-data-source=MyName/xa-datasource-properties=Password:remove
/subsystem=datasources/xa-data-source=MyName/xa-datasource-properties=Password:add(value="change-me")
:reload
xa-data-source enable --name=MyName
2021-02-09 18:17:18,610 INFO  (management-handler-thread - 1) [UID=,REQ=#] [org.jboss.as.connector] WFLYJCA0093: The 'disable' operation is deprecated. Use of the 'add' or 'remove' operations is preferred, or if required the 'write-attribute' operation can used to set the deprecated 'enabled' attribute

I don't know whether this is a new warning, but knowing JBoss, enabling/disabling may be removed in a future version.

Any thoughts on this?

This should be an easy fix to the xa rule file.

@rpelisse @sabre1041 thoughts? I don't have an env to test this atm, but I can do the rule fix.

@bserdar can you paste the fix here (or do a dirty, broken PR), @sabre1041, @hcherukuri or me will take care of integrating it properly!