Requires template elements

Question

Requires template elements

doublemarked opened this issue 11 years ago · 7 comments

doublemarked commented 11 years ago

The modal currently fails if the template contains no elements (just text).

stryju commented 11 years ago

🍻

Answer 1 · 2014-03-03T02:01:55.000Z

not sure if it should throw or automagically wrap the elt. thoughts?

Answer 2 · 2014-03-03T08:33:51.000Z

I would opt for automatic wrapping.

Answer 3 · 2014-04-17T07:09:41.000Z

does it make sense?

modal should be a self contained element, like a window etc - so making it wrap the content makes no sense IMO
how would you even style it? :-)

Answer 4 · 2014-04-17T07:58:52.000Z

My head isn't in this problem any more, but @stryju you may be right. Perhaps the proper solution is to throw an exception if there's no element. That is probably a more disciplined approach.

Answer 5 · 2014-04-18T00:14:40.000Z

Landed in v0.2.2.

Answer 6 · 2014-04-18T00:14:59.000Z

My resolution, by the way, was to throw if there are just text nodes.