btford/write-good

Glob no longer working

jputrino opened this issue · 5 comments

jputrino commented

Following the recent commits, our checks that use globs are no longer working. Every attempt to run write-good *.rst results in a "not a valid argument" error:

putrino: docs (develop)$ write-good --version
0.12.0
putrino: docs (develop)$ write-good *.rst
"index.rst" is not a valid argument.
putrino: docs (develop)$ write-good ./*.rst
"./index.rst" is not a valid argument.
putrino: docs (develop)$ write-good ./index.rst
In ./index.rst
=============
simply *AS3*) is a flexible, low-overhead mechanism for managing
^^^^^^
"simply" can weaken meaning on line 12 at column 0
-------------
Schema, and declarations validate according to JSON Schema. AS3 accepts
                         ^^^^^^^^
"validate" is wordy or unneeded on line 17 at column 30
RichardLitt commented

@TimKam Looks like we didn't catch this with the tests. Can you help out with this?

@jputrino Thanks for letting us know! We recently merged a new CLI tool, and it looks like this use case wasn't covered. Sorry about that. Any help in the form of a PR would be great.

TimKam commented

I'm so sorry! I added a PR for a quick fix, but did not write tests, yet.

RichardLitt commented

@TimKam Let's add some tests first. Thanks for moving so fast!

RichardLitt commented

@jputrino This should be good now! Reinstall, let me know, and let's see if we can close this. Thanks, @TimKam.

jputrino commented

It works!! @RichardLitt @TimKam Thanks so much, you rock!

  • 🎉2