Add version checking logic

Question

Add version checking logic

btkelly opened this issue 9 years ago · 7 comments

The library should be able to look at various forms of version strings or version codes and deduce which version is higher / lower. This will involve major and minor numbers, ex "1.2.1 vs 1.3.0" and "1.5 vs 2.1" as well as a version code that may be only an integer. The consumer should be able to configure what the library is evaluating, the version name or the version code.

Answer 1 · 2016-01-18T18:44:35.000Z

This library might be useful to us: https://github.com/zafarkhaja/jsemver

Answer 2 · 2016-01-18T20:14:39.000Z

For 1.0, we'll be using the version code exclusively, as it is required to be both an integer, and to be higher than the previous.

Answer 3 · 2016-01-18T20:15:22.000Z

Should this be assigned to a different milestone then? 2.0?

Answer 4 · 2016-01-18T20:18:47.000Z

I think we should just close it for now, might be better to stick with the version code. Thoughts?

Answer 5 · 2016-01-18T20:21:50.000Z

Do we care about the iOS implementation, and matching that?

Answer 6 · 2016-01-18T20:22:42.000Z

They have a build number, we were thinking we should use that for iOS

Answer 7 · 2016-01-18T20:22:57.000Z

Sounds good!