buckaroo-it/BuckarooSDK_PHP

BP-2351 TransactionResponse::getSubStatusCode() returns string

Closed this issue · 2 comments

Typehinting for the TransactionResponse::getSubStatusCode() method states that the method should return an integer or null, but in my response, $this->data['Status']['SubCode']['Code'] is a string (S990). This is causing a fatal error on PHP 8.

PHP Fatal error: Uncaught TypeError: Return value of Buckaroo\Transaction\Response\TransactionResponse::getSubStatusCode() must be of the type int or null, string returned in vendor/buckaroo/sdk/src/Transaction/Response/TransactionResponse.php:295

Dear @tombroucke

Thanks for mentioning the issue. I will look into it.

Fixed #88