filename does not contain clustername

Question

filename does not contain clustername

Closed this issue a year ago · 6 comments

it looks like the clustername is missing in the config filenames?

➜  talos talhelper genconfig
generated config for master1 in ./clusterconfig/-master1.yaml
generated config for master2 in ./clusterconfig/-master2.yaml
generated config for master3 in ./clusterconfig/-master3.yaml
generated config for worker1 in ./clusterconfig/-worker1.yaml
generated client config in ./clusterconfig/talosconfig
generated .gitignore file in ./clusterconfig/.gitignore
➜  talos cat talconfig.yaml 
  clustername: mycluster
  talosVersion: v1.5.2
  endpoint: https://10.0.30.80:6443
  nodes:
    - hostname: master1
      ipAddress: 10.0.30.81
      installDisk: /dev/sda
      controlPlane: true
    - hostname: master2
      ipAddress: 10.0.30.82
      installDisk: /dev/sda
      controlPlane: true
    - hostname: master3
      ipAddress: 10.0.30.83
      installDisk: /dev/sda
      controlPlane: true
    - hostname: worker1
      ipAddress: 10.0.30.84
      installDisk: /dev/nvme1
      controlPlane: false
➜  talos  talhelper --version
talhelper version 1.12.0

Answer 1 · 2023-09-17T03:30:47.000Z

Hello @runningman84. It's clusterName and not clustername :)

Answer 2 · 2023-09-17T04:06:14.000Z

Also thanks for the issue because I just realized that the program should detect it and refuse to proceed. Looks like the library that unmarshal the yaml file doesn't work with wrong capital spelling. Will fix this soon.

Answer 3 · 2023-09-17T10:38:26.000Z

Okay I have that from some docs…

Answer 4 · 2023-09-21T10:08:43.000Z

Closing this, the new behavior should not allow a mistyped clusterName to continue. Thanks!

Answer 5 · 2023-09-23T15:06:19.000Z

Okay I have found the source for the wrong config:

Workflow:
  Create talconfig.yaml file defining your nodes information like so:
  ----------------------------------------
  clustername: mycluster
  talosVersion: v1.0
  endpoint: https://192.168.200.10:6443
  nodes:
    - hostname: master1
      ipAddress: 192.168.200.11
      installDisk: /dev/sdb
      controlPlane: true
    - hostname: worker1
      ipAddress: 192.168.200.21
      installDisk: /dev/nvme1
      controlPlane: false
  ----------------------------------------

as you see the output of talhelper itself suggests a wrong config

Answer 6 · 2023-09-23T15:37:52.000Z

Ah sorry about that, will be fixed in the next version. Thanks!