budimanjojo/talhelper

compute-plane config doesn't contain `cluster.clusterName`

cwrau opened this issue · 4 comments

cwrau commented

This results in the machine not displaying the clusterName on the dashboard, instead it just prints n/a

Currently, we fix this with the following;

patches:
  - |-
    - op: add
      path: /cluster/clusterName
      value: <clusterName>
budimanjojo commented

Thanks for reporting!
But can you provide your talconfig.yaml file so I can try to reproduce?

cwrau commented

Thanks for reporting! But can you provide your talconfig.yaml file so I can try to reproduce?

Sure;

# yaml-language-server: $schema=https://raw.githubusercontent.com/budimanjojo/talhelper/master/pkg/config/schemas/talconfig.json
clusterName: management-cluster
talosVersion: v1.6.5
kubernetesVersion: v1.27.0
endpoint: https://3.3.3.3:6443
nodes:
  - hostname: control-plane-0
    ipAddress: 1.1.1.1
    installDisk: /dev/sda
    controlPlane: true

  - hostname: compute-plane-0
    ipAddress: 2.2.2.2
    installDisk: /dev/sda
budimanjojo commented

Thanks for the provided information.
I just tried with your talconfig.yaml file, the cluster.clusterName is not set for the compute-plane-0 is because that node is a worker node.

I don't know the specific reason but seems like the API from Talos doesn't set cluster.clusterName for non controlplane nodes. You can verify this with talosctl gen config management-cluster https://3.3.3.3:6443 and see that the generated worker.yaml file also doesn't have cluster.clusterName set.

My guess is because you don't talk to worker node directly using talosconfig file so it just doesn't set it by default.

I can explicitly set it with talhelper if you really need it, but I need the reason from you. And I think this makes more sense to be fixed (if you really think it is a problem) from upstream instead of talhelper.

cwrau commented

Thanks for the provided information.
I just tried with your talconfig.yaml file, the cluster.clusterName is not set for the compute-plane-0 is because that node is a worker node.

I don't know the specific reason but seems like the API from Talos doesn't set cluster.clusterName for non controlplane nodes. You can verify this with talosctl gen config management-cluster https://3.3.3.3:6443 and see that the generated worker.yaml file also doesn't have cluster.clusterName set.

My guess is because you don't talk to worker node directly using talosconfig file so it just doesn't set it by default.

Oh, I didn't know that 🤔

I can explicitly set it with talhelper if you really need it, but I need the reason from you. And I think this makes more sense to be fixed (if you really think it is a problem) from upstream instead of talhelper.

No, it's no problem, just for aesthetics, I just thought the problem was with this tool not setting something

Great tool btw! 😁

  • ❤️1