bufferapp/android-clean-architecture-boilerplate

LastCacheTime will be updated even if data is accessed from CacheDataStore?

jdsingh opened this issue · 1 comments

jdsingh commented

android-clean-architecture-boilerplate/data/src/main/java/org/buffer/android/boilerplate/data/BufferooDataRepository.kt

Line 31 in f036554

return factory.retrieveDataStore().getBufferoos()

I think there is some problem here. If I understand it correctly when the factory.retrieveDataStore() returns the BufferooCacheDataStore then this code is just taking the data from the cache and again storing it in the cache and updating LastCacheTime.

This does not feel right. Is this intended behavior or some sort of issue?

hitherejoe commented

Oops, that's my bad - will fix that up today :) Good spot!

  • 👍1