buildkite/buildkite-agent-metrics

Without interval sometimes stats don't reach statsd

theist opened this issue · 0 comments

While testing buildkite-metrics with my test conditions, between two and five agents and 12 pipelines or so, I've fount that if you use only one loop (without interval) and statsd as backend (on localhost) most of the time the stats never get out of buildkite metrics. I've check this also with tcpdump to discard a problem with the statsd daemon.

Looking at the code there' s a buffered client with 100 comands buffer ad 100ms refresh. But somewhat seems that the program ends before the client send its payload by UDP.

I found a Flush method but it seems that the vendored version of the library does not support it.

I've prepared a PR that updates the statsd library and flushes the statsd client after each Collect