Array.apply not support ie8 in TextBlock even if I'm add the polyfill

Question

Array.apply not support ie8 in TextBlock even if I'm add the polyfill

Closed this issue 7 years ago · 10 comments

guxingke201 commented 7 years ago

could you change it to Array.from?

Answer 1 · 2017-12-15T09:02:28.000Z

ie8? seriously? not even Microsoft supports ie8 anymore 😝

Anyway, to answer to your two questions:

I'm sorry, but I don't think we should change the code to support a 10years old browser that is no longer officially supported by anyone. If you really need to support IE8, I suggest you polyfill Array.apply directly on your project
Array.from is muuuch more recent than Array.apply and is not even supported by IE11 => so I guess you're already using polyfills? In this case, adding the polyfill for Array.apply should not be a problem then :)

Answer 2 · 2017-12-15T09:26:57.000Z

I'm already try to use es3ify-loader and babel-polyfill to polyfill Array.apply,but failed. fortunately the Array.from success

Answer 3 · 2017-12-15T09:44:56.000Z

Ok, Array.apply is actually supported by IE8, but for some reason in IE8 it has a different API...

We could take advantage of ES6 by doing it as [...Array(5)] and let babel do their job

EDIT: babel uses Array.from so, no, I'm not gonna do it. I'll try another solution

Answer 4 · 2017-12-15T10:05:00.000Z

published a fix in 1.0.10

Answer 5 · 2017-12-18T01:37:06.000Z

I'm sorry to say that your another solution failed,because the range.map failed to traverse in ie8

Answer 6 · 2017-12-18T01:40:13.000Z

In addition if we don't use babel ,the problem will not just Array.apply

Answer 7 · 2017-12-18T01:48:48.000Z

if you don't want Array.from, you could replace range.map by for

Answer 8 · 2017-12-18T08:33:26.000Z

That's weird, I tested it on IE8 and it looked to me that it correctly initialized an array without errors.
What error are you getting? Can you write it here?

Answer 9 · 2017-12-19T01:55:31.000Z

There is no exception,just the range.map failed to loop in ie8, and I don't know why

Answer 10 · 2017-12-19T11:01:14.000Z

@guxingke201 I'm sorry, but if that didn't work I'm out of options: I'm not going to write bad code to support IE8.

I'm very pleased that you appreciate react-placeholder and wish to use it in your app, but I can't refactor code from ES6 to ES3 to support a browser that is 9 yo and no longer supported neither by Microsoft nor by React. I hope you will understand.

PS: to be honest, react-placeholder never even supported IE < 11 as it deeply uses flexbox for its layout :)

PPS: you should still be able to pass a custom placeholder, compatible with IE8, as children. You can look at this example for more information.