buildpacks/samples

publish packs/samples on update

ekcasey opened this issue · 1 comments

ekcasey commented

Add a builder.toml file to the root of buildpack/samples

When I push a change to buildpack/samples master branch
Then travis builds and publishes a new packs/samples
##Notes

  • should use pack create-builder and the builder.toml from the repo root
  • lifecycle travis should no longer publish packs/samples

Given I have pushed a new publish tag to buildpack/lifecycle
When travis has successfully built and pushed a new packs/build image
Then the buildpack/samples travis build is triggers and a new packs/samples image is built and publish using the updated packs/build as the base image

##Questions

  • as written this would imply that any changes to master are published, are we okay with that?
  • do we want this build to validate that the new packs/samples image works with pack cli (e.g. pack build --path <sample-app> --no-pull succeeds) before publishing?
ekcasey commented

now that there are real builders for folks to use, I don't think we should publish image