built-on-openfin/workspace-starter

SalesForce sample home is missing results when search in progress or query is less than min length

Closed this issue · 1 comments

Hi, I'm one of the devs from RocketFin, currently working on an engagement with a bank requiring us to integrate with SalesForce.
While setting up the SalesForce sample to get an understanding of how everything works, I noticed an issue with the home screen when a search is either in progress, or the query text does not meet the minimum requirement.
The gif below illustrates the issue.
before

I am able to PR this myself, however will require access to the repo to do so and raise PR.

Otherwise, you're welcome to slot this in yourselves:
how-to/integrate-with-salesforce/client/src/provider.ts around line 118

	if (salesforceIntegration?.getSearchResultsProgress) {
		const searching = await salesforceIntegration.getSearchResultsProgress(request.query, lastResponse, {
			queryMinLength: 3
		});
		results.push(...searching);
	}

The gif below illustrates functionality after the fix is applied.
after

Hi @mark-buhagiar-rocketfin,

Thanks for raising the issue. Yes, the bounce is something that was resolved in the more complex example workspace-platform-starter (where debouncing etc is implemented and it led us to adding the search function here as we import this integration as a module).

Thanks for the feedback and we have included it's use in the provider as well.

if (salesforceIntegration?.getSearchResultsProgress) {
(this version is coming to beta soon).