bukosabino/ta

VWAP indicator is wrong

Datamined opened this issue · 3 comments

In accordance with the definition of VWAP that you provide in the documentation VWAP should be calculated using cumulative volume, which is calculated from the start of the trading session (when we talk about relatively small timeframes, at least less than a day). There is no any rolling window in the definition, all volume since the day start (or other anchor) should be taken into account.

In other words, for each index this "rolling window size" should be equal to the index.
For instance, see the implementation here.

I second this. Just tried the library and VWAP was first indicator I used, immediately realised something was not right....

I third this issue. This indicator is completely wrong.

  1. reset period should be added
  2. 1 bar of the reset period does not use volume to calculate, just simple hcl3
    I m actually here to ask what is the window args