busterjs/buster

IE8 compatibility: use replacement for Array.some(..)

Closed this issue · 5 comments

Setup:

  • WinXP Pro SP3 32bit, node 0.6.11 via .msi installer, npm is 1.1.1 (came with the .msi)
  • buster 0.4.5 installed via npm with a few hacks by hand to get it going:
  • alongside buster/: pre-built contextify (ATTENTION: needs some more, not to be used as-is)
  • watch-tree installed via npm into buster/node_modules (used by buster-autotest, missing from deps) - yet this is defunct on Win
    -simple browser tests (html-scaffold only) use the 0.4.5 buster-test.js and buster-test.css from busterjs.org

Problem:
IE8 doesn't support Array.some(..) which is used in buster-test.js line 3408 (simple browser test)

Workaround:
My workaround at the moment is to set Array.prototype.some to my own if it's undefined.
However, I'm pretty sure you guys already have a replacement in place somewhere, just not always using it.

Note:
this one's pretty similar to #120 re Object.create(..), just the function and the line nr are different.

p.s.: I'm fully aware that Windows support is a thing for the future - just trying to help a little with it.

Thanks! Help with Windows support is greatly appreciated. Keep 'em coming!

Pretty quick you are, this I must say. Thanks :)
To help with actual patches i hope, in the future.

It's a pleasure closing such an awesome detailed bug report :) thanks again, and keep 'em coming!

Welcome you are and mine the pleasure is. And, y'know, coming I'll keep 'em; sure of this you can be :)