Should an attribute change trigger `inputModeDidChange` lifecycle hook?

Question

Should an attribute change trigger `inputModeDidChange` lifecycle hook?

Closed this issue 2 years ago · 1 comments

It's a bit unclear for me what the semantics are behind "input mode". Should a change in attributes, e.g. when centering a section, trigger inputModeDidChange?

NOTE TO PERSON FIXING THIS: If so, the conditions in https://github.com/bustle/mobiledoc-kit/blob/v0.12.0-0/src/js/editor/edit-state.js#L48 must be adapted accordingly.

Answer 1 · 2022-09-06T15:39:03.000Z

A change in attributes does trigger inputModeDidChange. The demo now utilizes this to show active toolbar button states for text alignment