Re-run .NET implementation (pedrosakuma)

Question

Re-run .NET implementation (pedrosakuma)

pedrosakuma opened this issue 8 months ago · 8 comments

pedrosakuma commented 8 months ago

Victor,

When you get the time, could you re-run with my last set of implementations?

https://github.com/pedrosakuma/1brc

Thanks a lot!

Answer 1 · 2024-01-11T00:19:32.000Z

I'm getting 5.503 vs 5.979 in the table.

Will update the table later.

Answer 2 · 2024-01-11T01:26:00.000Z

Hey Victor

I was expecting a more significant improvement, but i guess that maybe it rely on the hardware.

Thanks anyway!

Answer 3 · 2024-01-12T17:47:19.000Z

Hello Victor.

I think this is my last run, made some improvements.
Maybe this time it will show in the execution time.

Thanks in advance.

Answer 4 · 2024-01-12T19:41:30.000Z

Thanks!

BTW, you code cannot finish on this dataset gunnarmorling/1brc#246 (comment). Or it just take too long, I could not wait for more than 3 minutes.

Answer 5 · 2024-01-12T21:43:01.000Z

Thanks for the feedback!
I didnt know about this generator.

Answer 6 · 2024-01-12T21:51:34.000Z

Could you, please, try to make it work by tomorrow?

Answer 7 · 2024-01-13T00:23:13.000Z

It seems to be fixed, but had to rollback some performance improvements that made assumptions over the data.
But i guess that was the whole point of changing the file.
Thanks again for pointing that out

Answer 8 · 2024-01-13T15:24:42.000Z

See my blog post. You changes to work with 10K dataset made the default case significantly slower - but valid and accepted :)