Pulls Jest 21 to a project

Question

Closed this issue 6 years ago · 3 comments

Since there's "jest": "^21", in deps, looks like the profiler pulls Jest 21 into a project.

Do you think it would be possible to drop this requirement? Let's do peer deps for supported Jest range instead?

Answer 1 · 2018-12-19T16:47:56.000Z

You're right. I should have declared it as either a peer dependency or better still just via the docs. Want to send me a PR?

Answer 2 · 2018-12-19T17:03:24.000Z

Sure, will do.

On Wed, Dec 19, 2018, 17:47 Brian Vaughn ***@***.*** wrote: You're right. I should have declared it as either a peer dependency or better still just via the docs. Want to send me a PR? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKMCYQw_uP_oFI6z9lC54HI4LUJObaWks5u6m28gaJpZM4ZZ1TC> .

Answer 3 · 2018-12-19T17:05:03.000Z

Excellent. I'd say we should just remove it as a dependency entirely and just document the minimum version in the readme.