Profiler: Improve labels for times that round to 0.0ms
bvaughn opened this issue · 12 comments
A better thing to show would be "<0.1ms"
Hi, I tried to check the test app for something that shows a label of 0.0ms.
The least amount of time I was able to find was 0.1ms.
Can you give me an example that shows a label of 0.0ms?
Just write a few components that render null 😄
const Example = () => null;Ok i found one in the test app.
I can take a look at this :)
Ok I did some stuff.
Doesn't this look a bit odd?
Or is this what we are aiming for?
It does look a bit odd, but I think it's less confusing than "0ms of 0ms".
Alright.
To open a PR, should I just create a new branch on my local and push it to the project?
You should fork this repo, which GitHub makes pretty easy to do by clicking the "Fork" button in the top right.
Then you can add that fork to your copy of this repo, e.g.
git remote add submetu git@github.com:submetu/react-devtools-experimental.git
Then you can push your branch to your fork, e.g.
git push submetu your-branch
Then your Git client should show you a URL in the terminal that you can copy-paste to create a pull request with your branch, e.g.
https://github.com/bvaughn/react-devtools-experimental/compare/bvaughn:master...submetu:your-branch
Alright. Will do that tonight.
Thanks for the detailed instructions 👍
Maybe we can add this to the CONTRIBUTION.md of the project